nodeSolidServer / nodeSolidServer/node-solid-server

remove bootstrap dependency

未关闭
#1,867 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

主要语言
JavaScript
星标
1.8k
派生
308
PR 合并指标
30 天内没有已合并 PR

描述

NSS only use bootstrap icons. We may use SolidOS icons
We use bootstrap@4 latest open source license. This version has a vulnerability

https://matrix.to/#/!wAfwwonbRnRLYejFOR:gitter.im/$xFAiECLG1apc87yny74sGTrW87sA0cI6UNvSl5ctVR4?via=gitter.im&via=matrix.org&via=chat.semantic.works

Wednesday
* Noel De Martin
I use icons like this https://icones.js.org/
* Noel De Martin
So basically I look for the icons I want to use in that website, and then in my code I just write the <i- element (I don't have to import any library or anything), then when the app is built the SVGs are auto-replaced :)
Here's an example of using that in Umai: https://github.com/NoelDeMartin/umai/blob/a0d2887e8f70d93ee6f3b3d33b39452cea5874c9/src/components/AppHeaderUserMenu.vue#L18
and regarding colors, they use fillCurrent by default, so they'll have the same color as the text. It can also be overriden by setting the text color with CSS
* Tim Berners-Lee
Our icons are mostly from https://thenounproject.com/
* Noel De Martin
I see, it seems like most of them are plain SVGs (not part of any icon set). You can also add custom SVGs using this, for example I have a few here: https://github.com/NoelDeMartin/umai/tree/main/src/assets/icons
I'll see if I can integrate something like this in SolidOS :). It's also better to use icons from an icon set in order to keep a consistent visual identity, grabbing random SVGs from websites can create some UI inconsistencies
* Timea
this is because Sharon downloaded them from the new design.
I could ask the designer if they use some icon Library....
at the top of the meeting minutes find a link to a ticket where our current designs are. it's all figma.
* Tim Berners-Lee
I don't see why NounProject is not considered an icon set .. it has too many alternatives?
* Tim Berners-Lee
The icons are in https://github.com/SolidOS/solid-ui/tree/main/src/icons ... so we use consistent icons across SolidOS and also apps.
* Noel De Martin
* Tim Berners-Lee
I don't see why NounProject is not considered an icon set .. it has too many alternatives?
yeah, it's not an icon set, it's just a marketplace where anyone can upload their SVGs. Icon sets usually have a consistent style, etc. It's like using a font family, you can use as many font families as you want in a website, but it's usually better to choose a couple that look well together.
* Timea
it's just about the designers choice and the look of them.i can see what they say.

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

在仓库中搜索 bootstrap@4 依赖及其图标使用位置,然后检查 SolidOS 图标目录和链接的图标讨论,以寻找可能的替代方案。完成的标准是移除 Bootstrap 且不留下图标引用,并且替代方案已达成一致并经过验证。

由索引模型根据 Issue 内容生成。

评估

技术栈
bootstrap, javascript
领域
frontend
Issue 类型
重构
难度
4/5
预计耗时
3-5 天
活跃度
冷清
描述清晰度
需要澄清
新手友好度
35/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。