nodeSolidServer / nodeSolidServer/node-solid-server

remove bootstrap dependency

Aberta
#1,867 0 comentários 0 reações 0 responsáveis Ver no GitHub

Ninguém assumiu esta issue ainda.

Linguagem predominante
JavaScript
Estrelas
1.8k
Forks
308
Métricas de merge de PRs
Nenhum PR com merge em 30d

Descrição

NSS only use bootstrap icons. We may use SolidOS icons
We use bootstrap@4 latest open source license. This version has a vulnerability

https://matrix.to/#/!wAfwwonbRnRLYejFOR:gitter.im/$xFAiECLG1apc87yny74sGTrW87sA0cI6UNvSl5ctVR4?via=gitter.im&via=matrix.org&via=chat.semantic.works

Wednesday
* Noel De Martin
I use icons like this https://icones.js.org/
* Noel De Martin
So basically I look for the icons I want to use in that website, and then in my code I just write the <i- element (I don't have to import any library or anything), then when the app is built the SVGs are auto-replaced :)
Here's an example of using that in Umai: https://github.com/NoelDeMartin/umai/blob/a0d2887e8f70d93ee6f3b3d33b39452cea5874c9/src/components/AppHeaderUserMenu.vue#L18
and regarding colors, they use fillCurrent by default, so they'll have the same color as the text. It can also be overriden by setting the text color with CSS
* Tim Berners-Lee
Our icons are mostly from https://thenounproject.com/
* Noel De Martin
I see, it seems like most of them are plain SVGs (not part of any icon set). You can also add custom SVGs using this, for example I have a few here: https://github.com/NoelDeMartin/umai/tree/main/src/assets/icons
I'll see if I can integrate something like this in SolidOS :). It's also better to use icons from an icon set in order to keep a consistent visual identity, grabbing random SVGs from websites can create some UI inconsistencies
* Timea
this is because Sharon downloaded them from the new design.
I could ask the designer if they use some icon Library....
at the top of the meeting minutes find a link to a ticket where our current designs are. it's all figma.
* Tim Berners-Lee
I don't see why NounProject is not considered an icon set .. it has too many alternatives?
* Tim Berners-Lee
The icons are in https://github.com/SolidOS/solid-ui/tree/main/src/icons ... so we use consistent icons across SolidOS and also apps.
* Noel De Martin
* Tim Berners-Lee
I don't see why NounProject is not considered an icon set .. it has too many alternatives?
yeah, it's not an icon set, it's just a marketplace where anyone can upload their SVGs. Icon sets usually have a consistent style, etc. It's like using a font family, you can use as many font families as you want in a website, but it's usually better to choose a couple that look well together.
* Timea
it's just about the designers choice and the look of them.i can see what they say.

Guia de contribuição

Abrir o guia de contribuição

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Direção de pesquisa

Pesquise no repositório a dependência bootstrap@4 e seus usos de ícones; em seguida, analise o diretório de ícones do SolidOS e a discussão vinculada sobre ícones em busca de possíveis substituições. O trabalho estará concluído quando o Bootstrap for removido sem deixar referências a ícones e a abordagem de substituição tiver sido acordada e verificada.

Escrita pelo modelo de indexação a partir do texto da issue.

Avaliação

Stack de tecnologia
bootstrap, javascript
Domínio
frontend
Tipo de issue
Refatoração
Dificuldade
4/5
Tempo estimado
3-5 dias
Status de atividade
Pouca atividade
Clareza
Precisa de esclarecimento
Facilidade para iniciantes
35/100

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.