microsoft / microsoft/vscode-pull-request-github

Finding how to submit pending review comments is VERY hard

Ouverte
#8,751 22 commentaires 0 réactions 1 personne assignée Voir sur GitHub

Personne n'a encore pris cette issue.

info-needed
Langage dominant
TypeScript
Étoiles
2.6k
Forks
795
Merge moyen
1 j 4 h
PR mergées (30 j)
46

Description

  • Extension version: 0.144.0
  • VSCode Version: 1.120.0
  • OS: Linux
  • Repository Clone Configuration (single repository/fork of an upstream repository): Single repo
  • GitHub Product (GitHub.com/GitHub Enterprise version x.x.x): github.com

Steps to Reproduce:

  1. Check out a PR branch
  2. Use the "GitHub Pull Request" sidebar view to navigate files and add pending comments in the editor
  3. Struggle to find the "submit review" button
  4. Google how to do it, which suggests it should be in the command palette ... it is not
  5. Give up and go submit the pending review with a web browser
  6. Do this again 4 or 5 times
  7. Eventually discover that the embedded webview version of the PR can submit the pending comments

Why is there no more accessible button to submit the pending review? Loading the full web view for the PR is both non-discoverable, and it certainly feels like a very heavy weight and obtuse way to show a text box and 3 buttons.

I only even found that because of random right-clicking on things to see what the extension could do, and randomly came across Open Pull Request Description To The Side and clicked it purely out of curiosity, having no expectation that it would provide the only means I've found so far of surfacing the "Submit Review" button.

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.