microsoft / microsoft/vscode-pull-request-github

Finding how to submit pending review comments is VERY hard

Offen
#8,751 22 Kommentare 0 Reaktionen 1 zugewiesene Person Auf GitHub ansehen

Dieses Issue hat noch niemand übernommen.

info-needed
Vorherrschende Sprache
TypeScript
Sterne
2.6k
Forks
796
Ø Merge
1 T. 4 Std.
Gemergte PRs (30 T.)
46

Beschreibung

  • Extension version: 0.144.0
  • VSCode Version: 1.120.0
  • OS: Linux
  • Repository Clone Configuration (single repository/fork of an upstream repository): Single repo
  • GitHub Product (GitHub.com/GitHub Enterprise version x.x.x): github.com

Steps to Reproduce:

  1. Check out a PR branch
  2. Use the "GitHub Pull Request" sidebar view to navigate files and add pending comments in the editor
  3. Struggle to find the "submit review" button
  4. Google how to do it, which suggests it should be in the command palette ... it is not
  5. Give up and go submit the pending review with a web browser
  6. Do this again 4 or 5 times
  7. Eventually discover that the embedded webview version of the PR can submit the pending comments

Why is there no more accessible button to submit the pending review? Loading the full web view for the PR is both non-discoverable, and it certainly feels like a very heavy weight and obtuse way to show a text box and 3 buttons.

I only even found that because of random right-clicking on things to see what the extension could do, and randomly came across Open Pull Request Description To The Side and clicked it purely out of curiosity, having no expectation that it would provide the only means I've found so far of surfacing the "Submit Review" button.

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Erste Schritte

  1. Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
  3. Forke das Repository und arbeite in einem Branch.
  4. Öffne einen Pull Request, der die Issue-Nummer nennt.

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.