microsoft / microsoft/vscode-pull-request-github
Finding how to submit pending review comments is VERY hard
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- TypeScript
- Estrellas
- 2.6k
- Forks
- 795
- Merge medio
- 1 d 4 h
- PR fusionados (30 d)
- 46
Descripción
- Extension version: 0.144.0
- VSCode Version: 1.120.0
- OS: Linux
- Repository Clone Configuration (single repository/fork of an upstream repository): Single repo
- GitHub Product (GitHub.com/GitHub Enterprise version x.x.x): github.com
Steps to Reproduce:
- Check out a PR branch
- Use the "GitHub Pull Request" sidebar view to navigate files and add pending comments in the editor
- Struggle to find the "submit review" button
- Google how to do it, which suggests it should be in the command palette ... it is not
- Give up and go submit the pending review with a web browser
- Do this again 4 or 5 times
- Eventually discover that the embedded webview version of the PR can submit the pending comments
Why is there no more accessible button to submit the pending review? Loading the full web view for the PR is both non-discoverable, and it certainly feels like a very heavy weight and obtuse way to show a text box and 3 buttons.
I only even found that because of random right-clicking on things to see what the extension could do, and randomly came across Open Pull Request Description To The Side and clicked it purely out of curiosity, having no expectation that it would provide the only means I've found so far of surfacing the "Submit Review" button.
Guía de contribución
No hay ninguna guía de contribución indexada para este repositorio
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Evaluación
Este issue todavía no se ha evaluado.