microsoft / microsoft/TypeScript
[Auto-import] Quick Fix suggests invalid module specifiers that fail to resolve at runtime
Personne n'a encore pris cette issue.
- Langage dominant
- Go
- Étoiles
- 111k
- Forks
- 14.3k
- Merge moyen
- 2 j 4 h
- PR mergées (30 j)
- 132
Description
🔎 Search Terms
Auto-import suggest invalid
🕗 Version & Regression Information
Tried in: 5.9.3., 6.0.3 and 7.0.2
⏯ Playground Link
No response
💻 Code
The project uses "module": "nodenext" and "moduleResolution": "nodenext" with the following "imports" configuration in package.json:
"imports": {
"#*": {
"node": "./dist/*/index.js",
"default": "./dist/*.js"
}
}
Project structure:
src/
utils/
summarize/
index.ts // re‑exports summarize from summarize.ts
summarize.ts // export const summarize
index.ts // file where auto‑import is triggered
./vscode/settings.json:
"js/ts.preferences.importModuleSpecifier": "non-relative",
Steps to reproduce:
In src/index.ts, start typing summarize.
Trigger the Quick Fix auto‑import suggestions.
🙁 Actual behavior
With the "node" condition active and "js/ts.preferences.importModuleSpecifier": "non-relative" set, the LSP (Quick Fix) offers two alias suggestions for the same symbol:
- #utils/summarize - resolves correctly via "node" to ./dist/utils/summarize/index.js.
- #utils/summarize/summarize - would resolve only via the "default" condition, which is not active at runtime.
Selecting the second suggestion causes a runtime error:
node:internal/modules/esm/resolve:272 throw new ERR_MODULE_NOT_FOUND...
🙂 Expected behavior
Node.js uses only the first matching condition based on the active conditions.
The second alias is therefore never considered at runtime.
The auto‑import should suggest only valid module specifiers that matches the active conditions.
For example, both suggestions would be valid if the node condition were removed.
Additional information about the issue
The behavior is not limited to nodenext; it also occurs with other resolution modes and with customConditions.
Related issue: #62439, #50762
Would not be a breaking change for LSP suggestions (Quick Fix / Auto Fix), as they would simply no longer offer specifiers that are unresolvable at runtime.
Update – additional case with paths in tsconfig.json
The issue also occurs when combining "imports" (in package.json) and "paths" (in tsconfig.json). For example:
// package.json
"imports": {
"#*": "./dist/*/index.js"
}
// tsconfig.json
"paths": {
"#*": ["./src/*"]
}
With this setup, the Quick Fix suggests:
import { summarize } from "#utils/summarize"; -> valid.
import { summarize } from "#utils/summarize/summarize.js"; -> ERR_MODULE_NOT_FOUND
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Piste de recherche
Reproduisez le Quick Fix de src/index.ts en utilisant les imports de package.json, les chemins de tsconfig.json et les conditions NodeNext ou personnalisées décrites dans l’issue. Suivez la logique de TypeScript language-service concernant les spécificateurs de module des auto-imports et leurs résultats de résolution ; le travail est terminé lorsque les suggestions excluent les spécificateurs qui ne peuvent pas être résolus dans les conditions d’exécution actives, avec une couverture des imports et des chemins.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- node.js, typescript
- Domaine
- compilers, tooling
- Type d'issue
- Bug
- Difficulté
- 4/5
- Temps estimé
- 3-5 jours
- Activité
- Active
- Clarté
- Plutôt claire
- Accessibilité débutants
- 52/100