microsoft / microsoft/TypeScript
[Auto-import] Quick Fix suggests invalid module specifiers that fail to resolve at runtime
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- Go
- Sterne
- 111k
- Forks
- 14.3k
- Ø Merge
- 2 T. 4 Std.
- Gemergte PRs (30 T.)
- 132
Beschreibung
🔎 Search Terms
Auto-import suggest invalid
🕗 Version & Regression Information
Tried in: 5.9.3., 6.0.3 and 7.0.2
⏯ Playground Link
No response
💻 Code
The project uses "module": "nodenext" and "moduleResolution": "nodenext" with the following "imports" configuration in package.json:
"imports": {
"#*": {
"node": "./dist/*/index.js",
"default": "./dist/*.js"
}
}
Project structure:
src/
utils/
summarize/
index.ts // re‑exports summarize from summarize.ts
summarize.ts // export const summarize
index.ts // file where auto‑import is triggered
./vscode/settings.json:
"js/ts.preferences.importModuleSpecifier": "non-relative",
Steps to reproduce:
In src/index.ts, start typing summarize.
Trigger the Quick Fix auto‑import suggestions.
🙁 Actual behavior
With the "node" condition active and "js/ts.preferences.importModuleSpecifier": "non-relative" set, the LSP (Quick Fix) offers two alias suggestions for the same symbol:
- #utils/summarize - resolves correctly via "node" to ./dist/utils/summarize/index.js.
- #utils/summarize/summarize - would resolve only via the "default" condition, which is not active at runtime.
Selecting the second suggestion causes a runtime error:
node:internal/modules/esm/resolve:272 throw new ERR_MODULE_NOT_FOUND...
🙂 Expected behavior
Node.js uses only the first matching condition based on the active conditions.
The second alias is therefore never considered at runtime.
The auto‑import should suggest only valid module specifiers that matches the active conditions.
For example, both suggestions would be valid if the node condition were removed.
Additional information about the issue
The behavior is not limited to nodenext; it also occurs with other resolution modes and with customConditions.
Related issue: #62439, #50762
Would not be a breaking change for LSP suggestions (Quick Fix / Auto Fix), as they would simply no longer offer specifiers that are unresolvable at runtime.
Update – additional case with paths in tsconfig.json
The issue also occurs when combining "imports" (in package.json) and "paths" (in tsconfig.json). For example:
// package.json
"imports": {
"#*": "./dist/*/index.js"
}
// tsconfig.json
"paths": {
"#*": ["./src/*"]
}
With this setup, the Quick Fix suggests:
import { summarize } from "#utils/summarize"; -> valid.
import { summarize } from "#utils/summarize/summarize.js"; -> ERR_MODULE_NOT_FOUND
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Reproduziere den Quick Fix aus src/index.ts unter Verwendung der package.json-Imports, der tsconfig.json-Pfade und der in der Issue beschriebenen NodeNext- oder benutzerdefinierten Bedingungen. Verfolge die Logik des TypeScript language-service für Auto-Import-Modulspezifizierer und deren Auflösungsergebnisse; abgeschlossen ist die Aufgabe, wenn Vorschläge Spezifizierer ausschließen, die unter den aktiven Laufzeitbedingungen nicht aufgelöst werden können, mit Abdeckung für Imports und Pfade.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- node.js, typescript
- Bereich
- compilers, tooling
- Issue-Typ
- Bug
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Aktivitätsstatus
- Aktiv
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 52/100