microsoft / microsoft/TypeScript

[Auto-import] Quick Fix suggests invalid module specifiers that fail to resolve at runtime

Abierto
#64,171 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Bug
Lenguaje dominante
Go
Estrellas
111k
Forks
14.3k
Merge medio
2 d 4 h
PR fusionados (30 d)
132

Descripción

### 🔎 Search Terms

Auto-import suggest invalid

### 🕗 Version & Regression Information

Tried in: 5.9.3., 6.0.3 and 7.0.2

### ⏯ Playground Link

_No response_

### 💻 Code

The project uses `"module": "nodenext"` and `"moduleResolution": "nodenext"` with the following "imports" configuration in package.json:
```json
"imports": {
"#*": {
"node": "./dist/*/index.js",
"default": "./dist/*.js"
}
}
```

Project structure:
```text
src/
utils/
summarize/
index.ts // re‑exports summarize from summarize.ts
summarize.ts // export const summarize
index.ts // file where auto‑import is triggered
```

`./vscode/settings.json`:
```json
"js/ts.preferences.importModuleSpecifier": "non-relative",
```

Steps to reproduce:
In src/index.ts, start typing `summarize`.
Trigger the `Quick Fix` auto‑import suggestions.

### 🙁 Actual behavior

With the "node" condition active and "js/ts.preferences.importModuleSpecifier": "non-relative" set, the LSP (Quick Fix) offers two alias suggestions for the same symbol:
- #utils/summarize - resolves correctly via "node" to ./dist/utils/summarize/index.js.
- #utils/summarize/summarize - would resolve only via the "default" condition, which is not active at runtime.

Selecting the second suggestion causes a runtime error:
`node:internal/modules/esm/resolve:272 throw new ERR_MODULE_NOT_FOUND...`

### 🙂 Expected behavior

Node.js uses only the first matching condition based on the active conditions.
The second alias is therefore never considered at runtime.

The auto‑import should suggest only valid module specifiers that matches the active conditions.

For example, both suggestions would be valid if the `node` condition were removed.

### Additional information about the issue

The behavior is not limited to `nodenext`; it also occurs with other resolution modes and with customConditions.

Related issue: #62439, #50762

Would not be a breaking change for LSP suggestions (Quick Fix / Auto Fix), as they would simply no longer offer specifiers that are unresolvable at runtime.

**Update** – additional case with paths in tsconfig.json
The issue also occurs when combining "imports" (in package.json) and "paths" (in tsconfig.json). For example:

```json
// package.json
"imports": {
"#*": "./dist/*/index.js"
}

// tsconfig.json
"paths": {
"#*": ["./src/*"]
}
```
With this setup, the `Quick Fix` suggests:
`import { summarize } from "#utils/summarize";` -> valid.
`import { summarize } from "#utils/summarize/summarize.js";` -> `ERR_MODULE_NOT_FOUND`

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Reproduce el Quick Fix de src/index.ts utilizando los imports de package.json, las rutas de tsconfig.json y las condiciones NodeNext o personalizadas descritas en el issue. Traza la lógica de TypeScript language-service para los especificadores de módulo de auto-import y sus resultados de resolución; se considera terminado cuando las sugerencias excluyen los especificadores que no pueden resolverse bajo las condiciones de ejecución activas, con cobertura para imports y rutas.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
node.js, typescript
Área
compilers, tooling
Tipo de issue
Error
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Activo
Claridad
Bastante claro
Aptitud para principiantes
52/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.