microsoft / microsoft/TypeScript
Allow a type annotation for indicating the type of a destructured rest assignment
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Go
- Estrellas
- 111k
- Forks
- 14.4k
- Merge medio
- 1 d 19 h
- PR fusionados (30 d)
- 117
Descripción
Suggestion
I offer allow to assign type to rest in destructuring assignment.
🔍 Search Terms
destructuring assignment, desctructuring, rest
✅ Viability Checklist
My suggestion meets these guidelines:
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
- This feature would agree with the rest of TypeScript's Design Goals.
⭐ Suggestion
const { e, ...rest }: { e: number, ...rest: ICalculatedNumbers } = test;
For better understanding please check Use Cases
📃 Motivating Example
I wanted to assign new calculated value to destructured assigment to field that moved out to new variable by destructuring, but I can't do it because new type exists without field and I'm not able to assign new type to desctructuring assignment.
Provided example in Use Cases
💻 Use Cases
Current behavior in TypeScript
export interface INumbersE {
c: number;
d: number;
}
export interface INumbers {
a?: number;
b?: number;
c?: number;
d?: number;
e?: INumbersE;
}
export interface ICalculatedNumbers {
a?: number;
b?: number;
c?: number;
d?: number;
e?: number;
}
const calcTheNumber = (numbers: ICalculatedNumbers) => {
// another logic goes there
console.log(numbers);
}
const test: INumbers = {
a: 1,
b: 2,
c: 3,
d: 4,
e: {
c: 2,
d: 3
}
};
const { e, ...rest }: { e: number, ...rest: ICalculatedNumbers } = test; // Property 'rest' is missing in type 'INumbers' but required in type '{ e: number; rest: ICalculatedNumbers; }'
if (e && e.c + e.d === 5) { // Property 'd' does not exist on type 'number' || Property 'c' does not exist on type 'number'
rest.e = 5; // Property 'e' does not exist on type '{ a: number; b: number; c: number; d: number; }'
}
calcTheNumber(rest); // Type '{ rest: ICalculatedNumbers; }' has no properties in common with type 'ICalculatedNumbers'.
Running in pure JS right as expected behavior and getting expected object with e: 5
const test = {
a: 1,
b: 2,
c: 3,
d: 4,
e: {
c: 2,
d: 3
}
};
const calcTheNumber = (numbers) => {
console.log(numbers); // { a: 1, b: 2, c: 3, d: 4, e: 5 }
}
const { e, ...rest } = test;
if (e && e.c + e.d === 5) {
rest.e = 5;
}
calcTheNumber(rest);
If cover errors with //@ts-ignore, it'll run as expected, but I'm not ok with that.
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
No se nombra ningún archivo, prueba ni punto de entrada. Empieza revisando la sintaxis de anotación de destructuring-rest propuesta y los ejemplos motivadores; se considera terminado cuando el comportamiento previsto de comprobación de tipos está acordado y cubierto por pruebas del compilador.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- javascript, typescript
- Área
- compilers
- Tipo de issue
- Nueva funcionalidad
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 30/100