microsoft / microsoft/TypeScript
Allow a type annotation for indicating the type of a destructured rest assignment
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- Go
- Sterne
- 111k
- Forks
- 14.4k
- Ø Merge
- 1 T. 19 Std.
- Gemergte PRs (30 T.)
- 117
Beschreibung
Suggestion
I offer allow to assign type to rest in destructuring assignment.
🔍 Search Terms
destructuring assignment, desctructuring, rest
✅ Viability Checklist
My suggestion meets these guidelines:
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
- This feature would agree with the rest of TypeScript's Design Goals.
⭐ Suggestion
const { e, ...rest }: { e: number, ...rest: ICalculatedNumbers } = test;
For better understanding please check Use Cases
📃 Motivating Example
I wanted to assign new calculated value to destructured assigment to field that moved out to new variable by destructuring, but I can't do it because new type exists without field and I'm not able to assign new type to desctructuring assignment.
Provided example in Use Cases
💻 Use Cases
Current behavior in TypeScript
export interface INumbersE {
c: number;
d: number;
}
export interface INumbers {
a?: number;
b?: number;
c?: number;
d?: number;
e?: INumbersE;
}
export interface ICalculatedNumbers {
a?: number;
b?: number;
c?: number;
d?: number;
e?: number;
}
const calcTheNumber = (numbers: ICalculatedNumbers) => {
// another logic goes there
console.log(numbers);
}
const test: INumbers = {
a: 1,
b: 2,
c: 3,
d: 4,
e: {
c: 2,
d: 3
}
};
const { e, ...rest }: { e: number, ...rest: ICalculatedNumbers } = test; // Property 'rest' is missing in type 'INumbers' but required in type '{ e: number; rest: ICalculatedNumbers; }'
if (e && e.c + e.d === 5) { // Property 'd' does not exist on type 'number' || Property 'c' does not exist on type 'number'
rest.e = 5; // Property 'e' does not exist on type '{ a: number; b: number; c: number; d: number; }'
}
calcTheNumber(rest); // Type '{ rest: ICalculatedNumbers; }' has no properties in common with type 'ICalculatedNumbers'.
Running in pure JS right as expected behavior and getting expected object with e: 5
const test = {
a: 1,
b: 2,
c: 3,
d: 4,
e: {
c: 2,
d: 3
}
};
const calcTheNumber = (numbers) => {
console.log(numbers); // { a: 1, b: 2, c: 3, d: 4, e: 5 }
}
const { e, ...rest } = test;
if (e && e.c + e.d === 5) {
rest.e = 5;
}
calcTheNumber(rest);
If cover errors with //@ts-ignore, it'll run as expected, but I'm not ok with that.
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Es wird keine Datei, kein Test und kein Einstiegspunkt genannt. Beginne mit der Überprüfung der vorgeschlagenen Destructuring-Rest-Annotationssyntax und der motivierenden Beispiele; abgeschlossen ist dies, wenn das beabsichtigte Verhalten der Typprüfung vereinbart und durch Compiler-Tests abgedeckt ist.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- javascript, typescript
- Bereich
- compilers
- Issue-Typ
- Feature
- Schwierigkeit
- 5/5
- Geschätzter Aufwand
- Über eine Woche
- Aktivitätsstatus
- Veraltet
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 30/100