microsoft / microsoft/TypeScript
Provide flag for projects to ban compile-time side-effects in root files
まだ誰も着手していません。
- 主要言語
- Go
- スター
- 111k
- フォーク
- 14.3k
- 平均マージ
- 2日 4時間
- マージ済み PR(30日)
- 132
説明
Search Terms
- pure
- side-effects
- elision
- global-modifying
Suggestion
A new tsconfig flag should be added that bans compile-time side-effects in project root files. This idea was originally proposed by @andrewbranch in response to an external pull request. The flag name can be discussed further, but examples might be noTypingSideEffects, noGlobalModifyingModules, noCompileTimeSideEffects, pure etc. The phrase "compile-time side-effects" refers to anything that can affect type-checking dependent source files outside of the standard export syntax.
The TypeScript features that allow source files to modify typing information outside of their file scope include the following:
- ambient modules
- module augmentation
- global augmentation
- global variables
- global functions
- triple-slash directives
- ... and potentially more
With this flag enabled, an error should appear on any usages of the above.
It may be worth allowing the flag (or a separate option) to specify allowlisted files that are expected to have side-effects. Notably, webpack's sideEffects option is a boolean | string[] type for this purpose.
Comparison to bundler tree-shaking
This idea is inspired by bundler tree-shaking, but focuses on side-effects at compile-time rather than runtime. The ideas are similar but different enough to warrant a specific TypeScript flag.
For example, a file that calls console.log on import has a runtime side-effect bundlers may care about but does not have any affect on typing. The allowlisted array of files with side-effects will likely be different between TypeScript and bundlers.
Use Cases
Banning compile-time side-effects allows future speed improvements. Notably, the compiler can now know whether source files and its import tree can be safely elided from a Program if its exported identifiers are unused. This has potentially significant speed and memory improvements depending on the source file graph of a program.
A quick and unfinished implementation that only looks at export { ... } from "..." syntax was created in PR #40966.
Examples
For a program with the following files, TypeScript should output:
a.ts(2,0): 'someGlobalVar' is a global variable, which is banned by the 'noTypingSideEffects' compiler option.
// tsconfig.json
{
"compilerOption": {
"noTypingSideEffects": true
},
"files": ["index.ts", "a.ts"]
}
// index.ts
import { a } from "./a";
console.log(someGlobalVar);
// a.ts
export const a = 1;
declare var someGlobalVar = 2;
Checklist
My suggestion meets these guidelines:
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
- This feature would agree with the rest of TypeScript's Design Goals.
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
調査の方向性
まず PR #40966 と、ambient module、module augmentation と global augmentation、global declaration、triple-slash directive に関する issue の例を確認します。関連する TypeScript compiler のエントリーポイントとテストを特定する前に、コンパイル時の副作用の正確な範囲と、コンパイラーオプションの allowlist の動作を定義します。指定されたケースで、出力される JavaScript を変更せずに診断が生成されれば完了です。
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- typescript
- 領域
- compilers
- issue の種類
- 機能追加
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 活発さ
- 停滞
- 明瞭さ
- おおむね明確
- 初心者へのやさしさ
- 35/100