microsoft / microsoft/TypeScript
Provide flag for projects to ban compile-time side-effects in root files
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Go
- Estrellas
- 111k
- Forks
- 14.4k
- Merge medio
- 1 d 19 h
- PR fusionados (30 d)
- 117
Descripción
Search Terms
- pure
- side-effects
- elision
- global-modifying
Suggestion
A new tsconfig flag should be added that bans compile-time side-effects in project root files. This idea was originally proposed by @andrewbranch in response to an external pull request. The flag name can be discussed further, but examples might be noTypingSideEffects, noGlobalModifyingModules, noCompileTimeSideEffects, pure etc. The phrase "compile-time side-effects" refers to anything that can affect type-checking dependent source files outside of the standard export syntax.
The TypeScript features that allow source files to modify typing information outside of their file scope include the following:
- ambient modules
- module augmentation
- global augmentation
- global variables
- global functions
- triple-slash directives
- ... and potentially more
With this flag enabled, an error should appear on any usages of the above.
It may be worth allowing the flag (or a separate option) to specify allowlisted files that are expected to have side-effects. Notably, webpack's sideEffects option is a boolean | string[] type for this purpose.
Comparison to bundler tree-shaking
This idea is inspired by bundler tree-shaking, but focuses on side-effects at compile-time rather than runtime. The ideas are similar but different enough to warrant a specific TypeScript flag.
For example, a file that calls console.log on import has a runtime side-effect bundlers may care about but does not have any affect on typing. The allowlisted array of files with side-effects will likely be different between TypeScript and bundlers.
Use Cases
Banning compile-time side-effects allows future speed improvements. Notably, the compiler can now know whether source files and its import tree can be safely elided from a Program if its exported identifiers are unused. This has potentially significant speed and memory improvements depending on the source file graph of a program.
A quick and unfinished implementation that only looks at export { ... } from "..." syntax was created in PR #40966.
Examples
For a program with the following files, TypeScript should output:
a.ts(2,0): 'someGlobalVar' is a global variable, which is banned by the 'noTypingSideEffects' compiler option.
// tsconfig.json
{
"compilerOption": {
"noTypingSideEffects": true
},
"files": ["index.ts", "a.ts"]
}
// index.ts
import { a } from "./a";
console.log(someGlobalVar);
// a.ts
export const a = 1;
declare var someGlobalVar = 2;
Checklist
My suggestion meets these guidelines:
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
- This feature would agree with the rest of TypeScript's Design Goals.
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Comienza revisando el PR #40966 y los ejemplos del issue sobre módulos ambient, ampliación de módulos y del ámbito global, declaraciones globales y directivas triple-slash. Define el alcance preciso de los efectos secundarios en tiempo de compilación y el comportamiento de la allowlist de la opción del compilador antes de identificar los puntos de entrada y las pruebas relevantes del compilador de TypeScript. Se considera terminado cuando los casos especificados producen diagnósticos sin cambiar el JavaScript emitido.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- typescript
- Área
- compilers
- Tipo de issue
- Nueva funcionalidad
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 35/100