microsoft / microsoft/TypeScript

Enum-specific interfaces enums could implement

未关闭
#39,773 1 条评论 2 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

Awaiting More Feedback Suggestion
主要语言
Go
星标
111k
派生
14.3k
平均合并
2 天 4 小时
30 天内合并 PR
132

描述

Search Terms

  • enum interface typescript
  • enum implements typescript

Suggestion

Make interfaces work with enums.

Enum interface

An interface describing what an enum should look like.

enum interface EnumInterface {
  Ok,
  NotOk
}
Enum implements enum interface

Enum implements an enum interface by including in its values the fields described by the interface.

enum EnumName implements EnumInterface {
  Ok,
  NotOk,
  Other
}

This mechanism should also work for const enums. The same interface should be implementable by both a const enum and a regular enum.

An enum interface could require for the enum to have a specific value, although it is not necessary.

An enum interface which has strict requirements for both the names and values would throw an error where either the name is not present in the enum implementing the interface or if the name is present but the value is not the same as the one defined in the interface.

enum interface EnumInterface {
  Ok=0,
  NotOk=1
}

Use Cases

Let say I'm creating an API. Each response I encode as a const enum result. Each of the response has some of the same results, (same possible errors) for example:

Both a

  • POST /post (creating a post) request and a
  • DELETE /post (deleting a post) request

may trigger the same errors regarding lack of authentication. Here I demonstrate two const enums describing the possible results of the two endpoints.

const enum CreatePost {
  OK,
  NO_AUTHORIZATION,
  OTHER_ERROR
}

const enum DeletePost {
  OK,
  NO_AUTHORIZATION,
  AUTHORIZED_BUT_NOT_AN_OWNER
}

Now, before the API handler in a perfect world one could create a method of signature:

declare function requireAuthentication(
   request: Request,
   handler: Handler,
   makeError: (result: RESULTS) => Response
): Handler;

Which would be fine, but makeError needs to be called from inside the requireAuthentication with a known error like, NO_AUTHENTICATION. So what is needed is:

  • a status map object mapping from the kind of error that requireAuthentication middleware may trigger into the particular result of the particular endpoint (in this case either a CreatePost or DeletePost enum),
  • another parameter for the middleware requireAuthentication.
interface AuthenticationErrorMap<Result extends RESULTS> {
   NO_AUTHORIZATION: Result
}

declare function requireAuthenticationReal<Result extends RESULTS>(
   request: Request,
   handler: Handler,
   makeError: (result: Result) => Response,
   statusCodeMap: AuthenticationErrorMap<Result>
): Handler;

Now with a few endpoints this is fine, but in production one can have a large number of endpoints for which a status map object has to be constructed manually for each endpoint:

const statusMapCreatePost: AuthenticationErrorMap<CreatePost> = {
   NO_AUTHORIZATION: CreatePost.NO_AUTHORIZATION
};

Now this is a simplified example, but in real life one could have lots of endpoints and lots of possible ways for things to fail.

Examples

As for the solution, the perfect thing for this use-case would be to make an enum interface:

enum interface NeedsAuthorizationResults {
   NO_AUTHORIZATION
}

Which then could be implemented on all endpoints' result enums:

const enum CreatePost implements NeedsAuthorizationResults {
  OK,
  NO_AUTHORIZATION,
  OTHER_ERROR
}

const enum DeletePost implements NeedsAuthorizationResults {
  OK,
  NO_AUTHORIZATION,
  AUTHORIZED_BUT_NOT_AN_OWNER
}

Which would then stop us from having to create an object for each endpoint with the AuthenticationErrorMap type. Instead something like this could be written:

declare function requireAuthenticationProposal<Result extends NeedsAuthorizationResults>(
   request: Request,
   handler: Handler,
   makeError: (result: Result) => Response,
): Handler;

Playground.

Checklist

My suggestion meets these guidelines:

  • This wouldn't be a breaking change in existing TypeScript/JavaScript code
  • This wouldn't change the runtime behavior of existing JavaScript code
  • This could be implemented without emitting different JS based on the types of the expressions
  • This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
  • This feature would agree with the rest of TypeScript's Design Goals.

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

首先查看 enum-interface 提案、其 TypeScript Playground 示例以及链接的 TypeScript design goals。完整实现需要支持常规 enum 和 const enum,强制使用提议的成员名称和值,并验证所示的泛型用例。

由索引模型根据 Issue 内容生成。

评估

技术栈
typescript
领域
compilers
Issue 类型
功能
难度
5/5
预计耗时
一周以上
活跃度
停滞
描述清晰度
基本清楚
新手友好度
25/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。