microsoft / microsoft/TypeScript

Enum-specific interfaces enums could implement

Ouverte
#39,773 1 commentaire 2 réactions 0 personnes assignées Voir sur GitHub

Personne n'a encore pris cette issue.

Awaiting More Feedback Suggestion
Langage dominant
Go
Étoiles
111k
Forks
14.3k
Merge moyen
2 j 4 h
PR mergées (30 j)
132

Description

Search Terms

  • enum interface typescript
  • enum implements typescript

Suggestion

Make interfaces work with enums.

Enum interface

An interface describing what an enum should look like.

enum interface EnumInterface {
  Ok,
  NotOk
}
Enum implements enum interface

Enum implements an enum interface by including in its values the fields described by the interface.

enum EnumName implements EnumInterface {
  Ok,
  NotOk,
  Other
}

This mechanism should also work for const enums. The same interface should be implementable by both a const enum and a regular enum.

An enum interface could require for the enum to have a specific value, although it is not necessary.

An enum interface which has strict requirements for both the names and values would throw an error where either the name is not present in the enum implementing the interface or if the name is present but the value is not the same as the one defined in the interface.

enum interface EnumInterface {
  Ok=0,
  NotOk=1
}

Use Cases

Let say I'm creating an API. Each response I encode as a const enum result. Each of the response has some of the same results, (same possible errors) for example:

Both a

  • POST /post (creating a post) request and a
  • DELETE /post (deleting a post) request

may trigger the same errors regarding lack of authentication. Here I demonstrate two const enums describing the possible results of the two endpoints.

const enum CreatePost {
  OK,
  NO_AUTHORIZATION,
  OTHER_ERROR
}

const enum DeletePost {
  OK,
  NO_AUTHORIZATION,
  AUTHORIZED_BUT_NOT_AN_OWNER
}

Now, before the API handler in a perfect world one could create a method of signature:

declare function requireAuthentication(
   request: Request,
   handler: Handler,
   makeError: (result: RESULTS) => Response
): Handler;

Which would be fine, but makeError needs to be called from inside the requireAuthentication with a known error like, NO_AUTHENTICATION. So what is needed is:

  • a status map object mapping from the kind of error that requireAuthentication middleware may trigger into the particular result of the particular endpoint (in this case either a CreatePost or DeletePost enum),
  • another parameter for the middleware requireAuthentication.
interface AuthenticationErrorMap<Result extends RESULTS> {
   NO_AUTHORIZATION: Result
}

declare function requireAuthenticationReal<Result extends RESULTS>(
   request: Request,
   handler: Handler,
   makeError: (result: Result) => Response,
   statusCodeMap: AuthenticationErrorMap<Result>
): Handler;

Now with a few endpoints this is fine, but in production one can have a large number of endpoints for which a status map object has to be constructed manually for each endpoint:

const statusMapCreatePost: AuthenticationErrorMap<CreatePost> = {
   NO_AUTHORIZATION: CreatePost.NO_AUTHORIZATION
};

Now this is a simplified example, but in real life one could have lots of endpoints and lots of possible ways for things to fail.

Examples

As for the solution, the perfect thing for this use-case would be to make an enum interface:

enum interface NeedsAuthorizationResults {
   NO_AUTHORIZATION
}

Which then could be implemented on all endpoints' result enums:

const enum CreatePost implements NeedsAuthorizationResults {
  OK,
  NO_AUTHORIZATION,
  OTHER_ERROR
}

const enum DeletePost implements NeedsAuthorizationResults {
  OK,
  NO_AUTHORIZATION,
  AUTHORIZED_BUT_NOT_AN_OWNER
}

Which would then stop us from having to create an object for each endpoint with the AuthenticationErrorMap type. Instead something like this could be written:

declare function requireAuthenticationProposal<Result extends NeedsAuthorizationResults>(
   request: Request,
   handler: Handler,
   makeError: (result: Result) => Response,
): Handler;

Playground.

Checklist

My suggestion meets these guidelines:

  • This wouldn't be a breaking change in existing TypeScript/JavaScript code
  • This wouldn't change the runtime behavior of existing JavaScript code
  • This could be implemented without emitting different JS based on the types of the expressions
  • This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
  • This feature would agree with the rest of TypeScript's Design Goals.

Guide de contribution

Ouvrir le guide de contribution

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Piste de recherche

Commencez par examiner la proposition enum-interface, son exemple TypeScript Playground et les TypeScript design goals liés. Une implémentation complète devrait prendre en charge les enums réguliers et const, imposer les noms et les valeurs de membres proposés, et valider le cas d’utilisation générique présenté.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
typescript
Domaine
compilers
Type d'issue
Fonctionnalité
Difficulté
5/5
Temps estimé
Plus d'une semaine
Activité
À l'abandon
Clarté
Plutôt claire
Accessibilité débutants
25/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.