microsoft / microsoft/TypeScript
Allow narrowing type based on others properties when creating a new object
Nessuno ha ancora preso questa issue.
- Lingua principale
- Go
- Stelle
- 111k
- Fork
- 14.3k
- Merge medio
- 1g 19h
- PR unite (30g)
- 117
Descrizione
Search Terms
- narrowing type
Suggestion
Currently, TypeScript isn't narrowing the type based on others properties that is defined while creating a new object. For example. Let's say the we have the following function:
type TParams = { kind: 'name', value: string } | { kind: 'age', value: number }
const example = (params: TParams) => {
...
}
So we can call it using codes like:
example({ kind: 'name', value: 'macabeus' })
example({ kind: 'age', value: 23 })
But isn't possible to compile code like:
let nameOrAge: 'name' | 'age' = 'name'
example({
kind: nameOrAge,
value: (nameOrAge === 'name' ? 'macabeus' : 23),
})
but we know that, if nameOrAge is 'name', the property value will be a string, otherwise nameOrAge will be 'age' and value will be 23 - that is correct.
I think that would be useful if TS could check this behaviour.
Use Cases
It would be useful to reduce the amount of code on situations like described on the above section.
Currently, is necessary to write more lines to have the same behaviour:
let nameOrAge: 'name' | 'age' = 'name'
if (nameOrAge === 'name') {
example({
kind: nameOrAge,
value: 'macabeus',
})
} else {
example({
kind: nameOrAge,
value: 23,
})
}
Related
I know that there are a lot of issues saying about narrowing types based on variables, such as:
But here I'm saying only about when is creating a new object, and as far as I know is a simpler case if compared on these others issues, since doesn't need to track the entire code base.
On the case that I'm saying, TS just need to check the others properties defined on the same object and if the variable name already is used. For example, TS doesn't need to change its behaviour on this case:
example({
kind: nameOrAge,
value: otherVariabledDeclaredOnOtherScope ? 'macabeus' : 23,
}) // still should fail
Probably it isn't the best solution, but I think that it follow the Pareto efficiency.
Checklist
My suggestion meets these guidelines:
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
- This feature would agree with the rest of TypeScript's Design Goals.
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Direzione di ricerca
Inizia eseguendo la riproduzione collegata in TypeScript Playground e confrontandola con l’esempio del branch funzionante. Esamina come i letterali oggetto vengono verificati rispetto alle unioni discriminate; il lavoro è completo quando la combinazione proposta di kind e value viene accettata se correlata, mentre le variabili non correlate continuano a fallire, con la copertura della regressione aggiunta nella suite di test del compilatore.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- typescript
- Ambito
- compilers
- Tipo di issue
- Funzionalità
- Difficoltà
- 5/5
- Tempo stimato
- Più di una settimana
- Stato di attività
- Ferma
- Chiarezza
- Abbastanza chiara
- Idoneità per principianti
- 25/100