microsoft / microsoft/TypeScript
Allow narrowing type based on others properties when creating a new object
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Go
- Estrellas
- 111k
- Forks
- 14.4k
- Merge medio
- 1 d 19 h
- PR fusionados (30 d)
- 117
Descripción
Search Terms
- narrowing type
Suggestion
Currently, TypeScript isn't narrowing the type based on others properties that is defined while creating a new object. For example. Let's say the we have the following function:
type TParams = { kind: 'name', value: string } | { kind: 'age', value: number }
const example = (params: TParams) => {
...
}
So we can call it using codes like:
example({ kind: 'name', value: 'macabeus' })
example({ kind: 'age', value: 23 })
But isn't possible to compile code like:
let nameOrAge: 'name' | 'age' = 'name'
example({
kind: nameOrAge,
value: (nameOrAge === 'name' ? 'macabeus' : 23),
})
but we know that, if nameOrAge is 'name', the property value will be a string, otherwise nameOrAge will be 'age' and value will be 23 - that is correct.
I think that would be useful if TS could check this behaviour.
Use Cases
It would be useful to reduce the amount of code on situations like described on the above section.
Currently, is necessary to write more lines to have the same behaviour:
let nameOrAge: 'name' | 'age' = 'name'
if (nameOrAge === 'name') {
example({
kind: nameOrAge,
value: 'macabeus',
})
} else {
example({
kind: nameOrAge,
value: 23,
})
}
Related
I know that there are a lot of issues saying about narrowing types based on variables, such as:
But here I'm saying only about when is creating a new object, and as far as I know is a simpler case if compared on these others issues, since doesn't need to track the entire code base.
On the case that I'm saying, TS just need to check the others properties defined on the same object and if the variable name already is used. For example, TS doesn't need to change its behaviour on this case:
example({
kind: nameOrAge,
value: otherVariabledDeclaredOnOtherScope ? 'macabeus' : 23,
}) // still should fail
Probably it isn't the best solution, but I think that it follow the Pareto efficiency.
Checklist
My suggestion meets these guidelines:
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
- This feature would agree with the rest of TypeScript's Design Goals.
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Empieza ejecutando la reproducción vinculada de TypeScript Playground y compárala con el ejemplo de la rama funcional. Investiga cómo se comprueban los literales de objeto frente a uniones discriminadas; se considera terminado cuando se acepta la combinación propuesta de kind y value cuando están correlacionados y las variables no relacionadas siguen fallando, con cobertura de regresión añadida en la suite de pruebas del compilador.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- typescript
- Área
- compilers
- Tipo de issue
- Nueva funcionalidad
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 25/100