microsoft / microsoft/TypeScript
Allow narrowing type based on others properties when creating a new object
Personne n'a encore pris cette issue.
- Langage dominant
- Go
- Étoiles
- 111k
- Forks
- 14.3k
- Merge moyen
- 2 j 4 h
- PR mergées (30 j)
- 132
Description
Search Terms
- narrowing type
Suggestion
Currently, TypeScript isn't narrowing the type based on others properties that is defined while creating a new object. For example. Let's say the we have the following function:
type TParams = { kind: 'name', value: string } | { kind: 'age', value: number }
const example = (params: TParams) => {
...
}
So we can call it using codes like:
example({ kind: 'name', value: 'macabeus' })
example({ kind: 'age', value: 23 })
But isn't possible to compile code like:
let nameOrAge: 'name' | 'age' = 'name'
example({
kind: nameOrAge,
value: (nameOrAge === 'name' ? 'macabeus' : 23),
})
but we know that, if nameOrAge is 'name', the property value will be a string, otherwise nameOrAge will be 'age' and value will be 23 - that is correct.
I think that would be useful if TS could check this behaviour.
Use Cases
It would be useful to reduce the amount of code on situations like described on the above section.
Currently, is necessary to write more lines to have the same behaviour:
let nameOrAge: 'name' | 'age' = 'name'
if (nameOrAge === 'name') {
example({
kind: nameOrAge,
value: 'macabeus',
})
} else {
example({
kind: nameOrAge,
value: 23,
})
}
Related
I know that there are a lot of issues saying about narrowing types based on variables, such as:
But here I'm saying only about when is creating a new object, and as far as I know is a simpler case if compared on these others issues, since doesn't need to track the entire code base.
On the case that I'm saying, TS just need to check the others properties defined on the same object and if the variable name already is used. For example, TS doesn't need to change its behaviour on this case:
example({
kind: nameOrAge,
value: otherVariabledDeclaredOnOtherScope ? 'macabeus' : 23,
}) // still should fail
Probably it isn't the best solution, but I think that it follow the Pareto efficiency.
Checklist
My suggestion meets these guidelines:
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
- This feature would agree with the rest of TypeScript's Design Goals.
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Piste de recherche
Commencez par exécuter la reproduction liée dans TypeScript Playground et comparez-la avec l’exemple de la branche fonctionnelle. Étudiez la manière dont les littéraux d’objet sont vérifiés par rapport aux unions discriminées ; le travail est terminé lorsque la combinaison proposée de kind et value est acceptée lorsqu’elle est corrélée, tandis que les variables sans relation échouent toujours, avec une couverture de régression ajoutée dans la suite de tests du compilateur.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- typescript
- Domaine
- compilers
- Type d'issue
- Fonctionnalité
- Difficulté
- 5/5
- Temps estimé
- Plus d'une semaine
- Activité
- À l'abandon
- Clarté
- Plutôt claire
- Accessibilité débutants
- 25/100