microsoft / microsoft/TypeScript
Feature Request: Readonly<T> should remove mutable methods
まだ誰も着手していません。
- 主要言語
- Go
- スター
- 111k
- フォーク
- 14.3k
- 平均マージ
- 1日 19時間
- マージ済み PR(30日)
- 117
説明
Search Terms
readonly, as const, Readonly,
Suggestion
Readonly to work the way Readonly<T[]> does without having to create something like ReadonlyArray, ReadonlySet, etc...
I would love it if the Readonly<T> mapped type could exclude any method marked as readonly or maybe as cosnt or something similar.
Use Cases
At the moment I have to do this:
class Vector2 {
public constructor(
public x: number,
public x: number,
) {}
public add(other: ReadonlyVector2): Vector2 {
return this.clone().addInPlace(other);
}
public addInPlace(other: ReadonlyVector2): this {
this.x += other.x;
this.y += other.y;
return this;
}
public clone(): Vector2 {
return new Vector2(this.x, this.y);
}
}
interface ReadonlyVector2 {
readonly x: number;
readonly y: number;
add(other: ReadonlyVector2): Vector2;
clone(): Vector2;
}
This gets very boring with a lot of types, also it's error prone. I could forget to add something to the interface, or worse I could accidentally add something that is mutable.
I can currently do method(this: Readonly<this>) {...}, which is helpful, but doesn't stop me calling mutable methods on the type.
Inside a marked method you would be unable to mutate the state of member variables and you would unable to call other unmarked methods.
This would also allow you to remove the special case of Readonly<T[]>. The mutable methods of arrays could be marked with whatever syntax is decided and then Readonly<T[]> would just work like any other Readonly<T>. Currently I don't bother using Readonly<T> since it doesn't really help with anything except C style POD types.
Examples
class Vector2 {
public constructor(
public x: number,
public x: number,
) {}
public readonly add(other: Readonly<Vector2>): Vector2 {
return this.clone().addInPlace(other);
}
public addInPlace(other: Readonly<Vector2>): this {
this.x += other.x;
this.y += other.y;
return this;
}
public const clone(): Vector2 {
return new Vector2(this.x, this.y);
}
}
Checklist
My suggestion meets these guidelines:
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
- This feature would agree with the rest of TypeScript's Design Goals.
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
調査の方向性
実装ファイル、テスト、エントリーポイントのいずれも指定されていないため、まず提案とその型システムへの影響を確認してください。完了とするには、Readonly が可変メソッドをどのように識別して削除するかについて、Readonly<T[]> との関係および提案されているメソッドアノテーションを含む、合意された設計が必要です。
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- typescript
- 領域
- compilers
- issue の種類
- 機能追加
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 活発さ
- 停滞
- 明瞭さ
- おおむね明確
- 初心者へのやさしさ
- 30/100