microsoft / microsoft/TypeScript
Feature Request: Readonly<T> should remove mutable methods
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Go
- Estrellas
- 111k
- Forks
- 14.3k
- Merge medio
- 1 d 19 h
- PR fusionados (30 d)
- 117
Descripción
Search Terms
readonly, as const, Readonly,
Suggestion
Readonly to work the way Readonly<T[]> does without having to create something like ReadonlyArray, ReadonlySet, etc...
I would love it if the Readonly<T> mapped type could exclude any method marked as readonly or maybe as cosnt or something similar.
Use Cases
At the moment I have to do this:
class Vector2 {
public constructor(
public x: number,
public x: number,
) {}
public add(other: ReadonlyVector2): Vector2 {
return this.clone().addInPlace(other);
}
public addInPlace(other: ReadonlyVector2): this {
this.x += other.x;
this.y += other.y;
return this;
}
public clone(): Vector2 {
return new Vector2(this.x, this.y);
}
}
interface ReadonlyVector2 {
readonly x: number;
readonly y: number;
add(other: ReadonlyVector2): Vector2;
clone(): Vector2;
}
This gets very boring with a lot of types, also it's error prone. I could forget to add something to the interface, or worse I could accidentally add something that is mutable.
I can currently do method(this: Readonly<this>) {...}, which is helpful, but doesn't stop me calling mutable methods on the type.
Inside a marked method you would be unable to mutate the state of member variables and you would unable to call other unmarked methods.
This would also allow you to remove the special case of Readonly<T[]>. The mutable methods of arrays could be marked with whatever syntax is decided and then Readonly<T[]> would just work like any other Readonly<T>. Currently I don't bother using Readonly<T> since it doesn't really help with anything except C style POD types.
Examples
class Vector2 {
public constructor(
public x: number,
public x: number,
) {}
public readonly add(other: Readonly<Vector2>): Vector2 {
return this.clone().addInPlace(other);
}
public addInPlace(other: Readonly<Vector2>): this {
this.x += other.x;
this.y += other.y;
return this;
}
public const clone(): Vector2 {
return new Vector2(this.x, this.y);
}
}
Checklist
My suggestion meets these guidelines:
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
- This feature would agree with the rest of TypeScript's Design Goals.
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
No se nombra ningún archivo de implementación, prueba ni punto de entrada; empieza revisando la propuesta y sus implicaciones para el sistema de tipos. Se consideraría terminado cuando exista un diseño acordado sobre cómo Readonly identifica y elimina los métodos mutables, incluida la relación con Readonly<T[]> y las anotaciones de métodos propuestas.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- typescript
- Área
- compilers
- Tipo de issue
- Nueva funcionalidad
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 30/100