microsoft / microsoft/TypeScript
3.5 regression: return type forced more restrictive than needed
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Go
- Estrellas
- 111k
- Forks
- 14.4k
- Merge medio
- 1 d 19 h
- PR fusionados (30 d)
- 117
Descripción
TypeScript Version: 3.5.0-dev.20190508
Search Terms: restrictive return type
Code
class Box<A> {
constructor(public val: A) {}
}
interface ContainerFor<A> {
array: Array<A>;
box: Box<A>;
}
function single<T extends keyof ContainerFor<number>>(t: T, x: number): ContainerFor<number>[T] {
switch (t) {
case "array":
return new Array<number>(x);
case "box":
return new Box<number>(x);
}
return new Box<number>(0); // this should not be needed
}
function test() {
let t1 = single("array", 42);
let t2 = single("box", 42);
//let t3 = single("boo", 42);
}
Expected behavior:
This code worked with 3.4, but had an unsoundness bug in that single was allowed to return the wrong type (swap array and box). It was clear that switching over t did not increase knowledge about the expected output type and I was forced to have a fallback return which is of course unreachable. But the code itself worked.
The test function also shows things work as expected. The types for t1 and t2 are inferred correctly and asking for an unknown thing ("boo") is reported as an error.
I would expect this to still work in 3.5, perhaps fixing one of the issues I'm having in the internals of single.
Actual behavior:
Typescript 3.5 no longer accepts this code. returning new Array or new Box are flagged as wrong return types. The newly expected return type is now mandated to be the intersection type: number[] & Box<number>, which is too restrictive as the correct output type can be statically determined from T in the input. The fact that test correctly infers the output type is proof of this.
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Reproduce el ejemplo de función genérica con TypeScript 3.5.0-dev.20190508 y compara su comportamiento con TypeScript 3.4, centrándote en cómo el switch sobre T determina el tipo de retorno indexado. Se considera terminado cuando las ramas de array y Box se aceptan sin el fallback inalcanzable, mientras que las claves no válidas siguen produciendo errores.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- typescript
- Área
- compilers
- Tipo de issue
- Error
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 35/100