micro-ROS / micro-ROS/micro_ros_diagnostics

Translation indexes should be unsigned

Open
#33 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement help wanted
Dominant language
C
Stars
10
Forks
10
No merged PRs in 30d

Description

Currently, all indexes

  • HW_ID
  • TASK_ID
  • UPDATER_ID
  • KEY

are signed int16_t values, one shouldn't be indexing anything on a negative value (although could be possible). Thus, I'd suggest changing these indexes to be uint16_t instead.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the repository for the declarations and uses of HW_ID, TASK_ID, UPDATER_ID, and KEY, then inspect the surrounding translation-index code and any relevant checks. Done means all four indexes use uint16_t consistently without breaking their existing uses.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
embedded-iot
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.