micro-ROS / micro-ROS/micro_ros_diagnostics
Translation indexes should be unsigned
Open
enhancement
help wanted
- Dominant language
- C
- Stars
- 10
- Forks
- 10
- PR merge metrics
- No merged PRs in 30d
Description
Currently, all indexes
- `HW_ID`
- `TASK_ID`
- `UPDATER_ID`
- `KEY`
are signed int16_t values, one shouldn't be indexing anything on a negative value (although could be possible). Thus, I'd suggest changing these indexes to be uint16_t instead.
Contributor guide
Research direction
Search the repository for the declarations and uses of HW_ID, TASK_ID, UPDATER_ID, and KEY, then inspect the surrounding translation-index code and any relevant checks. Done means all four indexes use uint16_t consistently without breaking their existing uses.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- embedded-iot
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100