localstack / localstack/serverless-localstack

Protocol now required when using `custom.localstack.host`

未關閉
#257 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

還沒有人認領這個 Issue。

improve-error-messages status: backlog
主要語言
JavaScript
星號
542
分支
92
PR 合併指標
30 天內沒有已合併 PR

描述

## Description

Since serverless-loaclstack v1.2.1 it appears that the protocol needs to be included in the `custom.localstack.host` property.
In older versions it appears this was not required.

## Configuration

In our serverless configuration we had something similar to:
```yaml
custom:
localstack:
host: ${env:SOME_VAR, '127.0.0.1'}
```

i.e. without the protocol (`http://`).

## serverless-localstack v1.2.0:

Using this with:
- serverless: v3.36.0 (using an older version to be able test with older plugin versions)
- serverless-localstack: v1.2.0

The debug output shows:
```
Reconfiguring service acm to use http://127.0.0.1:4566
Reconfiguring service amplify to use http://127.0.0.1:4566
Reconfiguring service apigateway to use http://127.0.0.1:4566
```

## serverless-localstack v1.2.1:

Using this with:
- serverless: v3.36.0 (using an older version to be able test with older plugin versions)
- serverless-localstack: v1.2.1

The debug output shows:
```
Reconfiguring service acm to use 127.0.0.1://127.0.0.1:4566
Reconfiguring service amplify to use 127.0.0.1://127.0.0.1:4566
Reconfiguring service apigateway to use 127.0.0.1://127.0.0.1:4566
```

which then results in errors such as:
```
aws: [1] { UnknownEndpoint: Inaccessible host: `127.0.0.1' at port `443'. This service may not be available .....
```

## Additional information

In the documentation the example does include the protocol when setting the `custom.localstack.host` so I suppose it can also be seen as a configuration error on our end.. but in that case a clearer error message might be useful.

I'm also guessing the change in behavior is caused by #243

貢獻指南

開啟貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

研究方向

使用 serverless-localstack v1.2.0 和 v1.2.1 重現回報的設定,然後檢查 #243 中參照的變更,以及建構 LocalStack 端點的程式碼。完成的標準是:不帶通訊協定的主機要麼繼續像之前一樣運作,要麼產生明確的設定錯誤,並為此行為提供回歸測試涵蓋。

由索引模型根據 Issue 內容生成。

評估

技術堆疊
javascript
領域
devops
Issue 類型
缺陷
難度
3/5
預估耗時
1-2 天
活躍度
停滯
描述清晰度
基本清楚
新手友好度
38/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。