localstack / localstack/serverless-localstack

Protocol now required when using `custom.localstack.host`

未关闭
#257 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

improve-error-messages status: backlog
主要语言
JavaScript
星标
542
派生
92
PR 合并指标
30 天内没有已合并 PR

描述

## Description

Since serverless-loaclstack v1.2.1 it appears that the protocol needs to be included in the `custom.localstack.host` property.
In older versions it appears this was not required.

## Configuration

In our serverless configuration we had something similar to:
```yaml
custom:
localstack:
host: ${env:SOME_VAR, '127.0.0.1'}
```

i.e. without the protocol (`http://`).

## serverless-localstack v1.2.0:

Using this with:
- serverless: v3.36.0 (using an older version to be able test with older plugin versions)
- serverless-localstack: v1.2.0

The debug output shows:
```
Reconfiguring service acm to use http://127.0.0.1:4566
Reconfiguring service amplify to use http://127.0.0.1:4566
Reconfiguring service apigateway to use http://127.0.0.1:4566
```

## serverless-localstack v1.2.1:

Using this with:
- serverless: v3.36.0 (using an older version to be able test with older plugin versions)
- serverless-localstack: v1.2.1

The debug output shows:
```
Reconfiguring service acm to use 127.0.0.1://127.0.0.1:4566
Reconfiguring service amplify to use 127.0.0.1://127.0.0.1:4566
Reconfiguring service apigateway to use 127.0.0.1://127.0.0.1:4566
```

which then results in errors such as:
```
aws: [1] { UnknownEndpoint: Inaccessible host: `127.0.0.1' at port `443'. This service may not be available .....
```

## Additional information

In the documentation the example does include the protocol when setting the `custom.localstack.host` so I suppose it can also be seen as a configuration error on our end.. but in that case a clearer error message might be useful.

I'm also guessing the change in behavior is caused by #243

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

使用 serverless-localstack v1.2.0 和 v1.2.1 重现报告中的配置,然后检查 #243 中引用的更改以及构建 LocalStack 端点的代码。完成的标准是:不带协议的主机要么继续像以前一样工作,要么产生明确的配置错误,并为该行为提供回归覆盖。

由索引模型根据 Issue 内容生成。

评估

技术栈
javascript
领域
devops
Issue 类型
缺陷
难度
3/5
预计耗时
1-2 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
38/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。