localstack / localstack/serverless-localstack
Protocol now required when using `custom.localstack.host`
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- JavaScript
- Estrellas
- 542
- Forks
- 92
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Descripción
## Description
Since serverless-loaclstack v1.2.1 it appears that the protocol needs to be included in the `custom.localstack.host` property.
In older versions it appears this was not required.
## Configuration
In our serverless configuration we had something similar to:
```yaml
custom:
localstack:
host: ${env:SOME_VAR, '127.0.0.1'}
```
i.e. without the protocol (`http://`).
## serverless-localstack v1.2.0:
Using this with:
- serverless: v3.36.0 (using an older version to be able test with older plugin versions)
- serverless-localstack: v1.2.0
The debug output shows:
```
Reconfiguring service acm to use http://127.0.0.1:4566
Reconfiguring service amplify to use http://127.0.0.1:4566
Reconfiguring service apigateway to use http://127.0.0.1:4566
```
## serverless-localstack v1.2.1:
Using this with:
- serverless: v3.36.0 (using an older version to be able test with older plugin versions)
- serverless-localstack: v1.2.1
The debug output shows:
```
Reconfiguring service acm to use 127.0.0.1://127.0.0.1:4566
Reconfiguring service amplify to use 127.0.0.1://127.0.0.1:4566
Reconfiguring service apigateway to use 127.0.0.1://127.0.0.1:4566
```
which then results in errors such as:
```
aws: [1] { UnknownEndpoint: Inaccessible host: `127.0.0.1' at port `443'. This service may not be available .....
```
## Additional information
In the documentation the example does include the protocol when setting the `custom.localstack.host` so I suppose it can also be seen as a configuration error on our end.. but in that case a clearer error message might be useful.
I'm also guessing the change in behavior is caused by #243
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Reproduce la configuración reportada con serverless-localstack v1.2.0 y v1.2.1; después, inspecciona el cambio referenciado en #243 y el código que construye el endpoint de LocalStack. Se considerará terminado cuando un host sin protocolo siga funcionando como antes o produzca un error de configuración claro, con cobertura de regresión para este comportamiento.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- javascript
- Área
- devops
- Tipo de issue
- Error
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 38/100