jmespath / jmespath/jmespath.php
To fork or not to fork
- Ngôn ngữ chính
- PHP
- Star
- 2k
- Fork
- 57
- Chỉ số merge pull request
- Không có pull request nào được merge trong 30 ngày
Mô tả
Hey @GrahamCampbell I'm rudely pinging you, I hope you will forgive me.
We've recently switched to the clientside community implementation since the one here is no longer supported.
However we also use this implementation in our backend.
We've found some inconsistencies between the community implementation and the PHP and JS implementations here. In this case the community implementation is correct according to the spec.
My question to you is this: Would you accept PRs that fix spec compliance while breaking consistency with other libraries in this org?
I'd prefer not to fork this to the community org if we can instead maintain it here; on the other hand while you're keeping this alive, it's not being actively developed (no blame, just observation).
What would your preference be? Since we use JMESPath I'm happy to contribute in the form of a fork with the community or by making PRs here; but I'd love your opinion before I make a choice.
The specific issue we're running into is the case of an unquoted string inside a JSON literal:
```
[?abc == `def`]
```
Which is supported in this library: https://github.com/jmespath/jmespath.php/blob/master/src/Lexer.php#L432
The fix is easy of course, but we'd break consistency with the JS implementation.
The specification where this is defined lives here: https://github.com/jmespath-community/jmespath.spec/blob/main/jep-012-raw-string-literals.md
Which is obsoleted by 12a: https://github.com/jmespath-community/jmespath.spec/blob/main/jep-012a-raw-string-literals.md
TLDR; would you accept PRs that update this library to newer community specs or do you prefer to keep this implementation consistent with other implementations in this ORG?
Hướng dẫn đóng góp
Chưa lập chỉ mục được hướng dẫn đóng góp cho kho mã nguồn này
Hướng nghiên cứu
Start with src/Lexer.php around line 432 and compare the handling of [ ?abc == `def` ] with jmespath-community/jmespath.spec, especially JEP-012a. The issue first needs a maintainer decision about adopting newer community specifications versus preserving consistency with other implementations; only then can completion criteria be defined.
Do mô hình lập chỉ mục viết ra từ nội dung của issue.
Đánh giá
- Công nghệ
- php
- Lĩnh vực
- backend
- Loại issue
- Tính năng
- Độ khó
- 5/5
- Thời gian dự kiến
- Hơn một tuần
- Mức độ hoạt động
- Ít trao đổi
- Độ rõ ràng
- Cần làm rõ
- Mức phù hợp với người mới
- 25/100