jmespath / jmespath/jmespath.php
To fork or not to fork
- 主要语言
- PHP
- 星标
- 2k
- 派生
- 57
- PR 合并指标
- 30 天内没有已合并 PR
描述
Hey @GrahamCampbell I'm rudely pinging you, I hope you will forgive me.
We've recently switched to the clientside community implementation since the one here is no longer supported.
However we also use this implementation in our backend.
We've found some inconsistencies between the community implementation and the PHP and JS implementations here. In this case the community implementation is correct according to the spec.
My question to you is this: Would you accept PRs that fix spec compliance while breaking consistency with other libraries in this org?
I'd prefer not to fork this to the community org if we can instead maintain it here; on the other hand while you're keeping this alive, it's not being actively developed (no blame, just observation).
What would your preference be? Since we use JMESPath I'm happy to contribute in the form of a fork with the community or by making PRs here; but I'd love your opinion before I make a choice.
The specific issue we're running into is the case of an unquoted string inside a JSON literal:
```
[?abc == `def`]
```
Which is supported in this library: https://github.com/jmespath/jmespath.php/blob/master/src/Lexer.php#L432
The fix is easy of course, but we'd break consistency with the JS implementation.
The specification where this is defined lives here: https://github.com/jmespath-community/jmespath.spec/blob/main/jep-012-raw-string-literals.md
Which is obsoleted by 12a: https://github.com/jmespath-community/jmespath.spec/blob/main/jep-012a-raw-string-literals.md
TLDR; would you accept PRs that update this library to newer community specs or do you prefer to keep this implementation consistent with other implementations in this ORG?
贡献指南
这个仓库没有索引到贡献指南
调研方向
从 src/Lexer.php 第 432 行附近开始,并将 [ ?abc == `def` ] 的处理方式与 jmespath-community/jmespath.spec 进行比较,尤其是 JEP-012a。该 issue 首先需要 maintainer 决定是采用较新的社区规范,还是保持与其他实现的一致性;只有在此之后才能定义完成标准。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- php
- 领域
- backend
- Issue 类型
- 功能
- 难度
- 5/5
- 预计耗时
- 一周以上
- 活跃度
- 冷清
- 描述清晰度
- 需要澄清
- 新手友好度
- 25/100