jamulussoftware / jamulussoftware/jamulus
Refactor: Improve country code conversion failure modes
オープン
refactoring
- 主要言語
- C
- スター
- 1.1k
- フォーク
- 248
- 平均マージ
- 2日 3時間
- マージ済み PR(30日)
- 9
説明
> I'd rather "convert to wireformat" and "convert from wireformat" were both "safe" - i.e. returned "Error" (e.g. -1) or a valid response, given any integer value, then have the caller deal with the error as it sees fit. Having to "know" about the `IsCountryCodeSupported` on top of the conversion methods seems excessively complicated.
_Originally posted by @pljones in https://github.com/jamulussoftware/jamulus/pull/2829#discussion_r965319280_
コントリビューションガイド
評価
この issue はまだ評価されていません。