jamulussoftware / jamulussoftware/jamulus
Refactor: Improve country code conversion failure modes
Offen
refactoring
- Vorherrschende Sprache
- C
- Sterne
- 1.1k
- Forks
- 248
- Ø Merge
- 2 T. 3 Std.
- Gemergte PRs (30 T.)
- 9
Beschreibung
> I'd rather "convert to wireformat" and "convert from wireformat" were both "safe" - i.e. returned "Error" (e.g. -1) or a valid response, given any integer value, then have the caller deal with the error as it sees fit. Having to "know" about the `IsCountryCodeSupported` on top of the conversion methods seems excessively complicated.
_Originally posted by @pljones in https://github.com/jamulussoftware/jamulus/pull/2829#discussion_r965319280_
Beitragsleitfaden
Bewertung
Dieses Issue wurde noch nicht bewertet.