ipython / ipython/traitlets

Promise not to remove Sentinel?

オープン
#865 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る
主要言語
Python
スター
653
フォーク
217
平均マージ
2日 21時間
マージ済み PR(30日)
2

説明

In https://github.com/ipython/traitlets/commit/bbbdfbbf57d06487e3acd54d954fe512e5d1b693 Sentinel was made deprecated. In the warning it mentions it might be removed `"It was published by mistake, and may be removed in the future."`.

Sentinel is already used in traittypes, and now people are afraid this will cause a breakage in the future:
* https://github.com/jupyter-widgets/traittypes/issues/47

I think there is a tendency in the Python community to remove deprecated 'things', I think we should not do that.
Instead, we should try not to touch the deprecated parts, especially if they are 'islands of code' like the Sentinel class is, since it would not increase the maintainance burden at all I think.

Removal and renaming have caused a lot of pain and suffering for library maintainers and users and caused a lot of trust issues.

I suggest we either promise to not remove it, or mention we try to not do that.

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。