ipython / ipython/traitlets

Promise not to remove Sentinel?

Offen
#865 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
Python
Sterne
653
Forks
217
Ø Merge
2 T. 21 Std.
Gemergte PRs (30 T.)
2

Beschreibung

In https://github.com/ipython/traitlets/commit/bbbdfbbf57d06487e3acd54d954fe512e5d1b693 Sentinel was made deprecated. In the warning it mentions it might be removed `"It was published by mistake, and may be removed in the future."`.

Sentinel is already used in traittypes, and now people are afraid this will cause a breakage in the future:
* https://github.com/jupyter-widgets/traittypes/issues/47

I think there is a tendency in the Python community to remove deprecated 'things', I think we should not do that.
Instead, we should try not to touch the deprecated parts, especially if they are 'islands of code' like the Sentinel class is, since it would not increase the maintainance burden at all I think.

Removal and renaming have caused a lot of pain and suffering for library maintainers and users and caused a lot of trust issues.

I suggest we either promise to not remove it, or mention we try to not do that.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.