Why prematurely clone `self.config` in `update_config()`?
Aperta
- Lingua principale
- Python
- Stelle
- 653
- Fork
- 217
- Merge medio
- 2g 21h
- PR unite (30g)
- 2
Descrizione
In `Configurable.update_config()#L214` https://github.com/ipython/traitlets/blob/4da01bfdd675783ab64a21df015e49378d91cbd2/traitlets/config/configurable.py#L206-L218
the `config` attribute is deep-cloned before `_load_config()` has the chance to validate config-values.
In case of trait-errors, this clone is wasted.
Was that on purpose?
Guida per i contributori
Apri la guida per i contributori
Valutazione
Questa issue non è ancora stata valutata.