Why prematurely clone `self.config` in `update_config()`?
Ouverte
- Langage dominant
- Python
- Étoiles
- 653
- Forks
- 217
- Merge moyen
- 2 j 21 h
- PR mergées (30 j)
- 2
Description
In `Configurable.update_config()#L214` https://github.com/ipython/traitlets/blob/4da01bfdd675783ab64a21df015e49378d91cbd2/traitlets/config/configurable.py#L206-L218
the `config` attribute is deep-cloned before `_load_config()` has the chance to validate config-values.
In case of trait-errors, this clone is wasted.
Was that on purpose?
Guide de contribution
Ouvrir le guide de contribution
Évaluation
Cette issue n'a pas encore été évaluée.