Why prematurely clone `self.config` in `update_config()`?
Offen
- Vorherrschende Sprache
- Python
- Sterne
- 653
- Forks
- 217
- Ø Merge
- 2 T. 21 Std.
- Gemergte PRs (30 T.)
- 2
Beschreibung
In `Configurable.update_config()#L214` https://github.com/ipython/traitlets/blob/4da01bfdd675783ab64a21df015e49378d91cbd2/traitlets/config/configurable.py#L206-L218
the `config` attribute is deep-cloned before `_load_config()` has the chance to validate config-values.
In case of trait-errors, this clone is wasted.
Was that on purpose?
Beitragsleitfaden
Bewertung
Dieses Issue wurde noch nicht bewertet.