ipython / ipython/traitlets

Why prematurely clone `self.config` in `update_config()`?

Open
#446 5 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
653
Forks
217
Avg merge
2d 21h
Merged PRs (30d)
2

Description

In `Configurable.update_config()#L214` https://github.com/ipython/traitlets/blob/4da01bfdd675783ab64a21df015e49378d91cbd2/traitlets/config/configurable.py#L206-L218
the `config` attribute is deep-cloned before `_load_config()` has the chance to validate config-values.
In case of trait-errors, this clone is wasted.

Was that on purpose?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.