`Application.launch_instance()` does not return any `start()` values
- 主要言語
- Python
- スター
- 653
- フォーク
- 217
- 平均マージ
- 2日 21時間
- マージ済み PR(30日)
- 2
説明
Currently (v5.0.0.dev) `launch_instance()` method invokes `start()` without returning its value:
def launch_instance(cls, argv=None, **kwargs):
app = cls.instance(**kwargs)
app.initialize(argv)
app.start()
But the `start()` method by default returns the value from any sub-application:
def start(self):
if self.subapp is not None:
return self.subapp.start()
So any values returned from the *sub-app* are lost if `launch_instance()` is used.
Is that on purpose?
## Sidenote
Strangely, in jupyter, the `JupyterApp.launch_instance()` method returns whatever the `Application.launch_instance()` return, which is nothing of course, and the question is: why does it return a guranteed `None`?
コントリビューションガイド
調査の方向性
Start by reading Application.launch_instance() and Application.start(), then inspect any tests covering application startup and sub-applications. Confirm how JupyterApp.launch_instance() uses the result. Done means values returned by start(), including sub-application results, are preserved when launch_instance() is called, with regression coverage.
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- python
- 領域
- cli
- issue の種類
- バグ
- 難易度
- 2/5
- 見積もり時間
- 1〜3時間
- 活発さ
- 停滞
- 明瞭さ
- おおむね明確
- 初心者へのやさしさ
- 35/100