ipython / ipython/traitlets

`Application.launch_instance()` does not return any `start()` values

Open
#369 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
653
Forks
217
Avg merge
2d 21h
Merged PRs (30d)
2

Description

Currently (v5.0.0.dev) `launch_instance()` method invokes `start()` without returning its value:

def launch_instance(cls, argv=None, **kwargs):
app = cls.instance(**kwargs)
app.initialize(argv)
app.start()

But the `start()` method by default returns the value from any sub-application:

def start(self):
if self.subapp is not None:
return self.subapp.start()

So any values returned from the *sub-app* are lost if `launch_instance()` is used.

Is that on purpose?

## Sidenote
Strangely, in jupyter, the `JupyterApp.launch_instance()` method returns whatever the `Application.launch_instance()` return, which is nothing of course, and the question is: why does it return a guranteed `None`?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.