ionic-team / ionic-team/ionic-framework

feat(ion-modal): break point class & values

オープン
#30,562 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る
triage
主要言語
TypeScript
スター
52.7k
フォーク
13.3k
平均マージ
1日 15時間
マージ済み PR(30日)
51

説明

### Prerequisites

- [x] I have read the [Contributing Guidelines](https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#creating-an-issue).
- [x] I agree to follow the [Code of Conduct](https://ionicframework.com/code-of-conduct).
- [x] I have searched for [existing issues](https://github.com/ionic-team/ionic-framework/issues) that already include this feature request, without success.

### Describe the Feature Request

Add the breakpoint as a class name of the ion-modal.

### Describe the Use Case

As my app use border-radius, I had to apply the same to the modal _to keep it consistent_.

But when the modal it at the `1` breakpoint, I would like to remove the border-radius.

### Describe Preferred Solution

having a `breakpoint-[value]` class name, which will contain the value of the different possible breakpoint

### Describe Alternatives

Also possible to have only if the `ion-modal` is actually overflowing or not

```
nativeElement.scrollHeight > nativeElement.clientHeight
```

### Related Code

I could propose a PR if wished

### Additional Information

_No response_

コントリビューションガイド

コントリビューションガイドを開く

調査の方向性

Start by locating the ion-modal component and its breakpoint handling. Review how breakpoint values are represented and how modal classes are assigned. Done means the modal exposes a breakpoint-[value] class that reflects the active breakpoint and supports styling such as changing border-radius.

索引モデルが issue の本文から書いたものです。

評価

技術スタック
typescript
領域
frontend
issue の種類
機能追加
難易度
3/5
見積もり時間
1〜2日
活発さ
停滞
明瞭さ
おおむね明確
初心者へのやさしさ
45/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。