ionic-team / ionic-team/ionic-framework

feat(ion-modal): break point class & values

Ouverte
#30,562 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
triage
Langage dominant
TypeScript
Étoiles
52.7k
Forks
13.3k
Merge moyen
1 j 15 h
PR mergées (30 j)
51

Description

### Prerequisites

- [x] I have read the [Contributing Guidelines](https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#creating-an-issue).
- [x] I agree to follow the [Code of Conduct](https://ionicframework.com/code-of-conduct).
- [x] I have searched for [existing issues](https://github.com/ionic-team/ionic-framework/issues) that already include this feature request, without success.

### Describe the Feature Request

Add the breakpoint as a class name of the ion-modal.

### Describe the Use Case

As my app use border-radius, I had to apply the same to the modal _to keep it consistent_.

But when the modal it at the `1` breakpoint, I would like to remove the border-radius.

### Describe Preferred Solution

having a `breakpoint-[value]` class name, which will contain the value of the different possible breakpoint

### Describe Alternatives

Also possible to have only if the `ion-modal` is actually overflowing or not

```
nativeElement.scrollHeight > nativeElement.clientHeight
```

### Related Code

I could propose a PR if wished

### Additional Information

_No response_

Guide de contribution

Ouvrir le guide de contribution

Piste de recherche

Start by locating the ion-modal component and its breakpoint handling. Review how breakpoint values are represented and how modal classes are assigned. Done means the modal exposes a breakpoint-[value] class that reflects the active breakpoint and supports styling such as changing border-radius.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
typescript
Domaine
frontend
Type d'issue
Fonctionnalité
Difficulté
3/5
Temps estimé
1-2 jours
Activité
À l'abandon
Clarté
Plutôt claire
Accessibilité débutants
45/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.