ionic-team / ionic-team/ionic-framework

bug: IonModal animation of swipe to close gesture is broken if canDismiss specified

Đang mở
#30,129 0 bình luận 1 reaction 0 người được giao Xem trên GitHub
triage
Ngôn ngữ chính
TypeScript
Star
52.7k
Fork
13.3k
Merge trung bình
1 ngày 15 giờ
Pull request đã merge (30 ngày)
51

Mô tả

### Prerequisites

- [X] I have read the [Contributing Guidelines](https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#creating-an-issue).
- [X] I agree to follow the [Code of Conduct](https://ionicframework.com/code-of-conduct).
- [X] I have searched for [existing issues](https://github.com/ionic-team/ionic-framework/issues) that already report this problem, without success.

### Ionic Framework Version

v8.x

### Current Behavior

https://github.com/user-attachments/assets/982bdcc7-be75-4195-a1d5-bcedb41ff78f

### Expected Behavior

Animation works as expected, for example when canDismiss is not specified

https://github.com/user-attachments/assets/2a0ea9e2-f463-49b1-95ea-b2a2cf3aa6dd

### Steps to Reproduce

create modal that has canDismiss specified as function that returns true
```ts
async function canDismiss(data?: any, role?: string) {
return true;
}

return (



App




Open




Modal

dismiss()}>Close





To close this modal, please use the "Close" button provided. Note
that swiping the modal will not dismiss it.






);
```

### Code Reproduction URL

https://stackblitz.com/edit/k9wbj9qc?file=src%2Fmain.tsx

### Ionic Info

running in stackblitz

Ionic:

Ionic CLI : 5.4.16

Utility:

cordova-res : not installed
native-run : not installed

System:

NodeJS : v18.20.3
npm : 10.2.3
OS : Linux 5.0

### Additional Information

_No response_

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.