ionic-team / ionic-team/ionic-framework

bug: IonModal animation of swipe to close gesture is broken if canDismiss specified

Offen
#30,129 0 Kommentare 1 Reaktion 0 zugewiesene Personen Auf GitHub ansehen
triage
Vorherrschende Sprache
TypeScript
Sterne
52.7k
Forks
13.3k
Ø Merge
1 T. 15 Std.
Gemergte PRs (30 T.)
51

Beschreibung

### Prerequisites

- [X] I have read the [Contributing Guidelines](https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#creating-an-issue).
- [X] I agree to follow the [Code of Conduct](https://ionicframework.com/code-of-conduct).
- [X] I have searched for [existing issues](https://github.com/ionic-team/ionic-framework/issues) that already report this problem, without success.

### Ionic Framework Version

v8.x

### Current Behavior

https://github.com/user-attachments/assets/982bdcc7-be75-4195-a1d5-bcedb41ff78f

### Expected Behavior

Animation works as expected, for example when canDismiss is not specified

https://github.com/user-attachments/assets/2a0ea9e2-f463-49b1-95ea-b2a2cf3aa6dd

### Steps to Reproduce

create modal that has canDismiss specified as function that returns true
```ts
async function canDismiss(data?: any, role?: string) {
return true;
}

return (



App




Open




Modal

dismiss()}>Close





To close this modal, please use the "Close" button provided. Note
that swiping the modal will not dismiss it.






);
```

### Code Reproduction URL

https://stackblitz.com/edit/k9wbj9qc?file=src%2Fmain.tsx

### Ionic Info

running in stackblitz

Ionic:

Ionic CLI : 5.4.16

Utility:

cordova-res : not installed
native-run : not installed

System:

NodeJS : v18.20.3
npm : 10.2.3
OS : Linux 5.0

### Additional Information

_No response_

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.