ionic-team / ionic-team/ionic-cli

Ionic serve and live reload need security (expose all code to anyone on same network).

Đang mở
#2,711 7 bình luận 0 reaction 0 người được giao Xem trên GitHub
enhancement
Ngôn ngữ chính
TypeScript
Star
2k
Fork
682
Chỉ số merge pull request
Không có pull request nào được merge trong 30 ngày

Mô tả

Ionic serve and live reload need security, currently it exposes all code to anyone on same network. Its *very* helpful to be able to bind to external IP and open the URL on a bunch of ios and android devices and different browsers and have all of them refresh automatically with every code change. But this also opens it up to everyone else on the network.

It needs multiple sub-features, but the simplest and easiest to add should be this:
- Add basic http auth support. Developer will need to type in the a username/password only once when it run it for the first time. And it will allow them to allow access to others if they want to, change credentials in command-line parameters, etc... (https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Authorization)

These can be optionally added later:
- Add https support, even if with just a self-signed certificate. Will secure against network sniffers, and as a side-effect also allow testing for https compatibility of actual app.
- Maybe add a url parameter `?token=aaaaaa` with a random token to allow both security and easy sharing. I have seen some tools do this, but personally I would prefer http basic auth + https.

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.