ionic-team / ionic-team/ionic-cli

Ionic serve and live reload need security (expose all code to anyone on same network).

未关闭
#2,711 7 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
enhancement
主要语言
TypeScript
星标
2k
派生
682
PR 合并指标
30 天内没有已合并 PR

描述

Ionic serve and live reload need security, currently it exposes all code to anyone on same network. Its *very* helpful to be able to bind to external IP and open the URL on a bunch of ios and android devices and different browsers and have all of them refresh automatically with every code change. But this also opens it up to everyone else on the network.

It needs multiple sub-features, but the simplest and easiest to add should be this:
- Add basic http auth support. Developer will need to type in the a username/password only once when it run it for the first time. And it will allow them to allow access to others if they want to, change credentials in command-line parameters, etc... (https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Authorization)

These can be optionally added later:
- Add https support, even if with just a self-signed certificate. Will secure against network sniffers, and as a side-effect also allow testing for https compatibility of actual app.
- Maybe add a url parameter `?token=aaaaaa` with a random token to allow both security and easy sharing. I have seen some tools do this, but personally I would prefer http basic auth + https.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。