ionic-team / ionic-team/angular-toolkit
component generator does not respect --changeDetection Flag
- Linguagem predominante
- TypeScript
- Estrelas
- 73
- Forks
- 34
- Merge médio
- 6min
- PRs com merge (30d)
- 5
Descrição
**Steps to Reproduce:**
```
ionic start
npm install @angular/cli@7.3.4
ng g component Test --changeDetection=OnPush --entryComponent
```
**Output:**
Generated component:
```
import { Component, OnInit } from '@angular/core';
@Component({
selector: 'app-training-options',
templateUrl: './training-options.component.html',
styleUrls: ['./training-options.component.scss'],
})
export class TrainingOptionsComponent implements OnInit {
constructor() { }
ngOnInit() {}
}
```
**My `ionic info`:**
```
Ionic:
ionic (Ionic CLI) : 4.10.3 (C:\Users\distante\AppData\Roaming\npm\node_modules\ionic)
Ionic Framework : @ionic/angular 4.0.2
@angular-devkit/build-angular : 0.12.4
@angular-devkit/schematics : 7.3.4
@angular/cli : 7.3.4
@ionic/angular-toolkit : 1.4.0
System:
NodeJS : v10.14.1 (C:\Program Files\nodejs\node.exe)
npm : 6.5.0
OS : Windows 10
```
**Other Information:**
Using a Pure angular Project `ng g` generates the correct component.
Guia de contribuição
Direção de pesquisa
Reproduce the issue with the listed ionic start and ng generate component commands, then compare the Ionic toolkit generator with the Angular CLI generator, which reportedly handles the flag correctly. Trace how the component generator processes --changeDetection=OnPush; done means the generated component reflects the requested change-detection strategy.
Escrita pelo modelo de indexação a partir do texto da issue.
Avaliação
- Stack de tecnologia
- angular, typescript
- Domínio
- tooling
- Tipo de issue
- Bug
- Dificuldade
- 3/5
- Tempo estimado
- 1-2 dias
- Status de atividade
- Estagnada
- Clareza
- Razoavelmente clara
- Facilidade para iniciantes
- 35/100