ionic-team / ionic-team/angular-toolkit

component generator does not respect --changeDetection Flag

Aperta
#94 12 commenti 10 reazioni 0 assegnatari Vedi su GitHub
bug
Lingua principale
TypeScript
Stelle
73
Fork
34
Merge medio
6m
PR unite (30g)
5

Descrizione

**Steps to Reproduce:**
```
ionic start
npm install @angular/cli@7.3.4
ng g component Test --changeDetection=OnPush --entryComponent
```

**Output:**
Generated component:
```
import { Component, OnInit } from '@angular/core';

@Component({
selector: 'app-training-options',
templateUrl: './training-options.component.html',
styleUrls: ['./training-options.component.scss'],
})
export class TrainingOptionsComponent implements OnInit {

constructor() { }

ngOnInit() {}

}
```

**My `ionic info`:**
```
Ionic:

ionic (Ionic CLI) : 4.10.3 (C:\Users\distante\AppData\Roaming\npm\node_modules\ionic)
Ionic Framework : @ionic/angular 4.0.2
@angular-devkit/build-angular : 0.12.4
@angular-devkit/schematics : 7.3.4
@angular/cli : 7.3.4
@ionic/angular-toolkit : 1.4.0

System:

NodeJS : v10.14.1 (C:\Program Files\nodejs\node.exe)
npm : 6.5.0
OS : Windows 10
```

**Other Information:**
Using a Pure angular Project `ng g` generates the correct component.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.