ionic-team / ionic-team/angular-toolkit

component generator does not respect --changeDetection Flag

Open
#94 12 comments 10 reactions 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
73
Forks
34
Avg merge
6m
Merged PRs (30d)
5

Description

**Steps to Reproduce:**
```
ionic start
npm install @angular/cli@7.3.4
ng g component Test --changeDetection=OnPush --entryComponent
```

**Output:**
Generated component:
```
import { Component, OnInit } from '@angular/core';

@Component({
selector: 'app-training-options',
templateUrl: './training-options.component.html',
styleUrls: ['./training-options.component.scss'],
})
export class TrainingOptionsComponent implements OnInit {

constructor() { }

ngOnInit() {}

}
```

**My `ionic info`:**
```
Ionic:

ionic (Ionic CLI) : 4.10.3 (C:\Users\distante\AppData\Roaming\npm\node_modules\ionic)
Ionic Framework : @ionic/angular 4.0.2
@angular-devkit/build-angular : 0.12.4
@angular-devkit/schematics : 7.3.4
@angular/cli : 7.3.4
@ionic/angular-toolkit : 1.4.0

System:

NodeJS : v10.14.1 (C:\Program Files\nodejs\node.exe)
npm : 6.5.0
OS : Windows 10
```

**Other Information:**
Using a Pure angular Project `ng g` generates the correct component.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.