hyperstack-org / hyperstack-org/hyperstack

For validation, and doing server side computation must update all associated changed records

未關閉
#450 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
JavaScript
星號
538
分支
41
PR 合併指標
30 天內沒有已合併 PR

描述

In commit 36516765f840eade6a8862682dd5a12774b259cd a fix was made so that ActiveRecord#changed? would accept optionally the attribute that was changing. I.e. Job.changed? means anything in the job changes, vs Job.changed(:name) means did the name attribute change.

Before Job.changed?(:name) was returning the same as Job.changed?

When this fix was made the gather_records method stopped including has_many records that had changed when gathering the parent during a save. This is actually correct behavior according to Rails. However it is a breaking deprecation for some apps BTW.

The bigger problem is that during validations or computations of server_methods we DO want to save (temporarily) ALL related changed records so the computations can use any values that have changed on the client during the server computation.

So we need a flag (perhaps it is the same as the force flag) that can be used to force ALL related changed records to be saved.

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。