hyperstack-org / hyperstack-org/hyperstack

For validation, and doing server side computation must update all associated changed records

Aperta
#450 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
JavaScript
Stelle
538
Fork
41
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

In commit 36516765f840eade6a8862682dd5a12774b259cd a fix was made so that ActiveRecord#changed? would accept optionally the attribute that was changing. I.e. Job.changed? means anything in the job changes, vs Job.changed(:name) means did the name attribute change.

Before Job.changed?(:name) was returning the same as Job.changed?

When this fix was made the gather_records method stopped including has_many records that had changed when gathering the parent during a save. This is actually correct behavior according to Rails. However it is a breaking deprecation for some apps BTW.

The bigger problem is that during validations or computations of server_methods we DO want to save (temporarily) ALL related changed records so the computations can use any values that have changed on the client during the server computation.

So we need a flag (perhaps it is the same as the force flag) that can be used to force ALL related changed records to be saved.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.