hyperstack-org / hyperstack-org/hyperstack

For validation, and doing server side computation must update all associated changed records

未关闭
#450 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
JavaScript
星标
538
派生
41
PR 合并指标
30 天内没有已合并 PR

描述

In commit 36516765f840eade6a8862682dd5a12774b259cd a fix was made so that ActiveRecord#changed? would accept optionally the attribute that was changing. I.e. Job.changed? means anything in the job changes, vs Job.changed(:name) means did the name attribute change.

Before Job.changed?(:name) was returning the same as Job.changed?

When this fix was made the gather_records method stopped including has_many records that had changed when gathering the parent during a save. This is actually correct behavior according to Rails. However it is a breaking deprecation for some apps BTW.

The bigger problem is that during validations or computations of server_methods we DO want to save (temporarily) ALL related changed records so the computations can use any values that have changed on the client during the server computation.

So we need a flag (perhaps it is the same as the force flag) that can be used to force ALL related changed records to be saved.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。