hyperstack-org / hyperstack-org/hyperstack
QueuedMessages from unsent/expired Connections are getting left in the database
Đang mở
performance
- Ngôn ngữ chính
- JavaScript
- Star
- 538
- Fork
- 41
- Chỉ số merge pull request
- Không có pull request nào được merge trong 30 ngày
Mô tả
Lately I've noticed poor performance in our production database for the Hyperstack tables, and noticed we had about 400K QueuedMessages in the table. Upon looking in the code, I found this:
```ruby
# hyper-operation/lib/hyper-operation/transport/connection.rb:111
expired.delete_all
# hyper-operation/lib/hyper-operation/transport/connection.rb:173
inactive.delete_all
```
ActiveRecord `delete_all` does not run callbacks, so the dependent QueuedMessages are not being destroyed when the Connection is. This should be changed to `destroy_all` so that the QueuedMessages don't get left in the database and accumulate.
Hướng dẫn đóng góp
Đánh giá
Issue này chưa được đánh giá.